Inline findings hover state isn't work as expected in the MR changes tab
Summary
The hover state for inline findings (SAST & Code Quality) in the changes tab isn't working as expected.
Steps to reproduce
- Start by finding a project on GitLab that has inline findings enabled and includes SAST and/or Code Quality scanning in merge requests. You can use the provided demo project as an example: demo project.
- Once you're in the project, navigate to a merge request that has SAST and/or Code Quality findings.
- Inside the merge request, click on the
Changes
tab. This tab will show you all the code changes made in the merge request. - Now, look for a line of code that has multiple inline security findings. You can identify these lines by looking for severity icons in the gutter area of the code. To confirm that multiple findings are present on a line, you need to hover your cursor over the severity icon. The severity icon should fan out to display multiple severity icons if multiple findings are present.
- Finally, hover your cursor over the severity icon on any line that has multiple findings. As noted in the previous step, this action will display multiple severity icons indicating all findings associated with that line of code.
Example Project
jannik_lehmann/code-quality-test!4 (diffs)
What is the current bug behavior?
The icons do not expand (fan out) in the way they were intended (icons should overlap and remain on a single line).
What is the expected correct behavior?
Ensure that the icons expand in a way that they overlap each other, instead of overflowing to a new line. The layout should allow the icons to overlap gracefully without creating additional rows for the icons. This ensures a compact and visually organized presentation of the icons without disrupting the line structure or causing unnecessary line breaks.
Inline_security_findings_-_default_popover
Possible fixes
TBD...
Edited by Michael Fangman