Follow-up from "Remove the 'broken' mergeability check in favor of commits check"
The following discussion from !146937 (merged) should be addressed:
-
@patrickbajao started a discussion: (+2 comments) Can we remove this separately to ensure multiversion compatibility? Probably next milestone and we can create a separate issue for that.
I tested this locally on
master
and specifically only remove this line and haveswitch_broken_status
disabled and it resulted to this:This is to replicate the scenario wherein Javascript code is new but API is still using the old version. Won't see this on GitLab.com but this can happen on self-managed instances.
The MR has conflicts (
merge_status
iscannot_be_merged
). When FF is disabled and API is still using the old version, 2 checks will fail but thebroken_status
message won't be shown because it's no longer present. This is confusing since user will se 2 checks failed but only 1 is shown.