Design: MR changes tab (dropdown)

Problem

There is an overlap between the Commit with the Changes tab. I've asked on #development slack channel how often they use the dropdown:

https://gitlab.slack.com/archives/C02PF508L/p1702893111014519

How often (if at all) do you use the functionality in this dropdown in the MR?

CleanShot 2024-01-31 at 15.22.53@2x.png

Some great insights were:

Quite often. I’d say every 3rd review I’m doing. Especially when there is follow-up changes after the review. I sometimes choose a commit from the commit tab, because it’s easier than calculating which version. But when it’s just checking the previous version, I’d use the dropdown. And sometimes I use it even if I need a moment to calculate which version I want, because switching a tab seems like too much.

Could you also switch to a specific commit via the “Commits” tab, or is there any deeper reason why you prefer to use this dropdown?

@mvanremmerden I do look at the commits tab at certain times, but it doesn’t show the code for each commit/push separately unless you navigate to that commit. I would prefer to use this drop down because I’m able to concisely see what changes happened between two distinct pushes.

So you rather use the left side of the dropdown to compare an earlier version with the latest version, not to compare an earlier version with main?

Most likely, yes. Also agree with Marco and Paulina above on the ability to see changes made after a review. (edited) 

I find it useful but i often have to try different versions and click multiple times to find what I'm looking for. I wish i could see a more useful summary of the change, like count of lines changed or some sort of "name" instead of just "version n"

I use sporadically… the main thing that prevents me from using it more is whenever I rebase the version comparison doesn’t make sense anymore

if it would “survive rebases” I would use more often

+1 for using it frequently. I don't know of another other way to see changes made by a force push.But as Gabriel noted, it's really only useful when that force push doesn't include a rebase.

Proposal

Before After
CleanShot 2024-01-31 at 15.52.14@2x.png TBD
Edited by Alex Fracazo