Follow-up from "Hide keyboard shortcuts in tooltips when disabled"
The following discussion from !143067 (merged) should be addressed:
-
@lorenzvanherwaarden started a discussion: I do think we should add some test coverage though (unless we have some exceptions for testing tooltips).
Implementation plan
- For
header_actions.vue
,sidebar_assignees_widget.vue
,labels_select_root.vue
:- check the value we're passing for the tooltip, shortcut description and shortcut key
- also check these when
shouldDisableShortcuts() === true
- For
web_ide_link.vue
, check that we're adding a<kbd />
with the shortcut content in it if the action has a shortcut, and that it's not added whenshouldDisableShortcuts() === true
(even though it has a shortcut).