Follow-up from "Set default vuln report filter to 'Still Detected'"
The following discussion from !137186 (merged) should be addressed:
-
@sming-gitlab started a discussion: (+1 comment) Because of the immediate wachter on
selected
in the component, there is an extrafilter-changed
emit, so a couple indices were wrong. For some I incremented the index, for others I used the last one with.at(-1)
thoughts (non-blocking, nit): No suggestion here, but I wonder if we can better capture this explanation -- whether as a comment or a descriptive helper why we're checking the second emitter
🤔 Or perhaps we should add a test to check the immediate effect was called
🤔 But we can think about this as a follow-up to avoid bloating this MR. And if we make the change, we should adjust
status_filter_spec.js
since that filter also has theimmediate
effect.