Remove un-related `FreeUserCap` reference, and other improvements from "Draft: Code Suggestions GA alert for non owners"
-
Stop using FreeUserCap
in this method. -
Group together related logic in a new module method (#434254 (comment 1683121775)) -
Refactor the test for this method (!138971 (comment 1683118451)) -
Update CSS class usage (!138971 (comment 1683131791))
The following discussion from !138971 (merged) should be addressed:
-
@dstull
started a discussion: (+2 comments)suggestion (non-blocking):
Gosh, I know this is what we want here...but I feel like it has nothing to do with
FreeUserCap
and therefore we may want to either- define this logic for ourselves as a duplicate here in the helper
- move this logic to a group model layer
- ignore my suggestion and keep it as it is...as this code by definition isn't permanent(due to date constraints) anyway and won't be a factor long term
The following discussion from !138971 (merged) should be addressed:
-
@tkuah started a discussion: non-blocking: Please refactor to not repeat the application code. Otherwise it makes this test brittle, aka requires changes everytime the code the changes.
Edited by Ross Byrne