Revise merge request approval rule language
I tried to come up with non-negated phrases for Prevent editing approval rules in merge requests
that would result in the same field settings:
- Current: "Prevent editing approval rules in merge requests"
- Idea 1: "Protect approval rules in merge requests"
- Idea 2: "Lock approval rules in merge requests"
The following discussion from !136359 (merged) should be addressed:
-
@aqualls started a discussion: (+2 comments) @phikai a bit of a digression. This field is a good example of why TWs push back on feature flags and field names that include words of negation. It becomes difficult to describe the behavior without descending into word soup, because as described, we're enabling a negation. We could probably make it clearer by revising the displayed field names + help text. Some ideas:
- Protect approval rules in merge requests
- Lock approval rules in merge requests
If this is something you want me to pursue, spin up an issue. It's probably an easy set of string fixes.
Edited by Amy Qualls