Skip to content

Follow-up from "Delete unused BufferedIO class"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

The following discussion from !144002 (merged) should be addressed:

  • @furkanayhan started a discussion: (+1 comment)

    This comment is written in !132238 (merged) but now I am not sure if we should remove this file.

    Although gems/gitlab-http/spec/gitlab/http_v2/net_http_response_patch_spec.rb covers the patch, this spec file covers that this patch is applied by adding the gitlab-http gem in config/initializers/7_gitlab_http.rb.

    I am not saying we should do this in this MR but maybe as a follow-up, we should have this test in spec/initializers/gitlab_http_spec.rb (or spec/initializers/7_gitlab_http_spec.rb).

    Not only this but also other patches stated in gems/gitlab-http/lib/gitlab/http_v2/patches.rb.

Edited by 🤖 GitLab Bot 🤖