Migrate `table-class-haml` in `app/views/profiles/chat_names/index.html.haml`
Detected usage of deprecated table class inside HAML file.
Use the gl-table
class instead.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Martin Wortschack assigned to @wortschi
assigned to @wortschi
- 🤖 GitLab Bot 🤖 added devopsmanage sectiondev labels
added devopsmanage sectiondev labels
- Martin Wortschack set weight to 1
set weight to 1
- Martin Wortschack changed milestone to %16.5
changed milestone to %16.5
- Martin Wortschack added Pajamas component:card frontend groupimport and integrate maintenancerefactor severity4 workflowready for development + 1 deleted label and removed grouppersonal productivity label
added Pajamas component:card frontend groupimport and integrate maintenancerefactor severity4 workflowready for development + 1 deleted label and removed grouppersonal productivity label
- Martin Wortschack removed component:card label
removed component:card label
- Martin Wortschack added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Martin Wortschack created branch
426228-migrate-table-class-haml-in-app-views-profiles-chat_names-index-html-haml
to address this issuecreated branch
426228-migrate-table-class-haml-in-app-views-profiles-chat_names-index-html-haml
to address this issue - Martin Wortschack mentioned in merge request !132638 (merged)
mentioned in merge request !132638 (merged)
- Martin Wortschack added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Martin Wortschack added workflowverification label and removed workflowin review label
added workflowverification label and removed workflowin review label
- Maintainer
Hmm it seems that the scanner is not happy even with the added
gl-table
class. It seems to highlight the added.table
class but I am not sure if.gl-table
works without.table
. Maybe we should look into this again and if not sure ask the Foundations team as well? - Maintainer
Martin asked on Slack about this issue (discussion, internal) and this is the reply from
@markrian
:We don't have a meaningful migration story for tables in HAML yet, so I'd suggest putting that aside for now.
Given this, I think it's best to push this issue back to the backlog for now and revisit when there is a clear migration path.
1 - Justin Ho Tuan Duong changed milestone to %Backlog
changed milestone to %Backlog
- Justin Ho Tuan Duong added workflowblocked label and removed workflowverification label
added workflowblocked label and removed workflowverification label
- Amanda Rueda removed 1 deleted label
removed 1 deleted label