VSA: Missing empty state illustrations when request is invalid
Summary
All VSA empty states are missing illustrations when the query parameters are invalid – they aren't being passed to the emptyStateSvgPath
, noDataSvgPath
or noAccessSvgPath
props in ee/app/assets/javascripts/analytics/cycle_analytics/components/base.vue
.
Steps to reproduce
Visit https://gitlab.com/gitlab-org/gitlab/-/value_stream_analytics?created_after=2023-03-25&created_before=2023-09-22&value_stream_id=3160 as an example
What is the current bug behavior?
Empty states don't have illustrations.
What is the expected correct behavior?
Empty states have illustrations.
Relevant logs and/or screenshots
Implementation guide
- Ensure that illustration paths are still being passed to the
data-*
attributes when request params are invalid in the following pages (see #426001 (comment 1636320289) for possible fix):
Edited by Rudy Crespo