Re-add toggle in keyboard shortcuts modal
!123581 (merged) removes the toggle from the keyboard shortcuts modal. In this discussion we decided to intentionally remove it in that MR, knowing that it negatively impacts the UX, with the purpose to re-add it but with logic that supports its usage in user preferences page (when both the toggle in the modal and the checkbox in the page are present).
The logic could be: get the value of isKeyboardShortcutEnabled
once on page load from window.gon
, and once when toggling.
See the discussion for more context.