Default enable "remember me" for logins
If you look at the issues in this epic: &9368
We have a lot of folks complaining about losing their sessions. Primarily on mobile.
I was discussing this issue with @ifarkas and @eduardosanz and Imre said he could reproduce the issue on Safari. Steps:
- Open Safari
- Log into GitLab
- Close Safari
- Re-open Safari
- No longer logged into GitLab
Eduardo pointed out that this is expected behavior when "remember me" is nor selected during login. Sure enough, Imre re-did those steps with "remember me" and he was still logged in on Step 5.
I now have a theory that, even if there is a real session bug where users get logged out prematurely, some number of these bug reports are users who do not understand the behavior of the "Remember me" checkbox (which, Eduardo pointed out, behaves differently on Chrome vs Safari vs Firefox).
Why can't we default enable the Remember me checkbox?
For reference, GitHub.com and Google apps do not even show you a remember me checkbox during their login flows. We could keep ours but have it default enabled instead of default disabled. This way, closing Safari and re-opening it would not automatically end the user session.