Direct transfer - missing MR comments and issue comments
Our nightly QA tests indicate that the the numbers of mr_comments
and issue_comments
don't match when using Direct transfer to migrate projects, i.e., theres a reasonable number of comments missing on the target instance.
Example pipeline: https://gitlab.com/gitlab-org/manage/import/import-metrics/-/pipelines/922550788
⛔
Issue comments It appears that the missing issue comments are comments for events, i.e., system notes. For example, in https://gitlab.com/gitlab-org/manage/import/import-metrics/-/jobs/4603056059#L58 it says that the missing elements are:
["changed milestone to %\"11.6\"", "changed milestone to %\"12.0\"", "changed milestone to %\"12.1\"", "changed milestone to %\"12.2\"", "mentioned in issue #393", "mentioned in issue #396"].
The related issue on the source instance is https://gitlab.com/gitlab-migration-large-import-test/migration-test-project/-/issues/187 and it shows that those comments are system notes:
There are different types of system notes, and it looks like comments for only a subset of them are missing. The comment for the system note moved to gitlab-org/quality/testcases#64
has been imported properly.
Update / Observation:
See this comment below for more details. After !127097 (merged) got merged, it appears that the remaining missing comments have one thing in common which is that the missing note is the only note in the issue.
✅
MR comments This has been fixed already via !127097 (merged)
Click to expand
Missing MR comments are likely als system notes
For example, in https://gitlab.com/gitlab-org/manage/import/import-metrics/-/jobs/4603056059#L58 it says that the missing elements are:
["mentioned in merge request !1047"].
The related MR on the source instance is https://gitlab.com/gitlab-migration-large-import-test/migration-test-project/-/merge_requests/1045