Something went wrong while fetching comments. Please try again.
(Pending) deletion action is different between groups and projects
Problem
When deleting a group or project, it is necessary to delete the group or project in question twice to ensure it is completely deleted. This is because deletion protection is enabled by default for all groups and projects. The deletion call-to-action looks quite different between groups and projects.
During the first deletion step:
- Projects mention the project path. The button states
Delete project
. Background is in red. - Groups do not mention the group path. Headline is in red. The button states
Remove group
. See this discussion for further feedback.
During the second deletion step:
- Projects look almost identical to the first step. Background is in red.
- Groups contain a lot of bold messaging. Headline is in red. Background is grey. Headline changed to
Permanently Remove Group
.
Proposal
-
Align the wording to
Delete
. See #454586 (closed). -
The group deletion documentation needs to be updated and references to
remove
need to be replaced withdelete
. See !154110 (merged). - Align the visual presentation of the action between groups and projects
Update deletion action as follows
Implementation guide
- Go through partials in app/views/groups/settings/_advanced.html.haml#L32 and align text
- Align text in https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/views/projects/_remove.html.haml#L17
- See #397033 (comment 1888919633) for correct copy