Floating code discussions
Right now code discussions are displayed inline in the diff file, contributing to the file height. Example:
We should consider having floating code discussions on the merge request Changes page. With floating discussions we could improve the performance of the page by:
- Sending discussions code points first (which file on which lines contains discussions). That would allow to quickly display discussions indicators on the corresponding lines and have a rough idea of the diff file height. That could be later used in
content-visibility
or in Virtual Scrolling. That should also improve response times for the discussions because we'll no longer need to send the whole discussion first. - Sending discussion content on interaction: either click or visibility change.
The exact design of the floating discussions is to be determined. This could also be explored as a part of 🧘♂️ Restructure MRs to improve the usability o... (&5038 - closed).
Edited by Stanislav Lashmanov