Improve webhook test coverage

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

The following discussion from !113204 (merged) should be addressed:

• @leetickett-gitlab started a discussion: (+2 comments)

  Any bright ideas on tests we might add to prevent this happening again?

  I thought about a test on the model for the triggers, but that relies on the test being updated in order for it to start failing. If the model was forgotten, I suspect the test would be forgotten too.

  Perhaps we need a feature spec that does something like:

  • navigates to the hooks page
  • tries to add a hook with "all triggers" (e.g. looping through all checkboxes on the screen?)
  • saves
  • edits and ensures all the checkboxes are still checked?

  I suggest we approach this as a follow up? But perhaps you have a more elegant test suggestion? 💙