Failures in browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb | Verify Pipeline editor when CI has (in)valid syntax shows (in)valid validations
Summary
Failing job(s):
- https://gitlab.com/gitlab-org/gitlab/-/jobs/3851344029
- https://gitlab.com/gitlab-org/gitlab/-/jobs/3851172263
Failing spec(s): qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb
Corresponding test case(s):
Stack trace
1) Verify Pipeline editor when CI has invalid syntax shows invalid validations
Got 2 failures from failure aggregation block.
# ./qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb:94:in `block (5 levels) in <module:QA>'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb:91:in `block (4 levels) in <module:QA>'
1.1) Failure/Error: expect(show.ci_syntax_validate_message).to have_content('CI configuration is invalid')
expected to find text "CI configuration is invalid" in "Learn more"
# ./qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb:102:in `block (6 levels) in <module:QA>'
1.2) Failure/Error: expect(show.ci_syntax_validate_message).to have_content('CI configuration is invalid')
expected to find text "CI configuration is invalid" in "Learn more"
# ./qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb:111:in `block (6 levels) in <module:QA>'
2) Verify Pipeline editor when CI has valid syntax shows valid validations
Failure/Error: expect(show.ci_syntax_validate_message).to have_content('Pipeline syntax is correct')
expected to find text "Pipeline syntax is correct" in "Learn more"
# ./qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb:65:in `block (6 levels) in <module:QA>'
# ./qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb:64:in `block (5 levels) in <module:QA>'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_tabs_spec.rb:63:in `block (4 levels) in <module:QA>'
Screenshot / HTML page
The screenshots show the message is there, but the test is looking at the wrong element
Possible fixes
The UI was changed in !111881 (merged)
We need to update the test (maybe move the selector?). Trying that in !113185 (merged)
Edited by Mark Lapierre