Skip to content

Links to pending comments from footer broken

Summary

Clicking the Pending Comments chevron and then clicking on a comment no longer navigates to the comment. Also there seems to be a styling issue with the border.

Steps to reproduce

  1. Create an MR with a few changed files.
  2. Start a review and place a pending comment on each file.
  3. Click Pending Comments in footer
  4. Click a pending comment

What is the current bug behavior?

Page does not scroll to comment

What is the expected correct behavior?

Page scrolls to comment

Relevant logs and/or screenshots

Single file: pending_comments_navigation_bug)

Multiple files Screen_Recording_2023-02-16_at_09.58.14

Results of GitLab application Check

gitlab.com

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes