RegistrationsController: improve error messages / resilience related to Arkose
Related incident: #391231 (closed)
The source of these opaque failures was that the ENV vars ARKOSE_LABS_PRIVATE_KEY
and ARKOSE_LABS_PUBLIC_KEY
were present in the environment, which they should not have been.
The error message/handling should be improved.
In these failed RegistrationsController
specs, the user was not saved and then we got the opaque error NoMethodError: undefined method 'preferred_language' for nil:NilClass
. I would expect to see an Arkose-related error in this scenario.
Now that !111641 (merged) is merged, setting these ENV vars will not result in the same failures. But we should write a new test scenario for when stub_feature_flags(arkose_labs_signup_challenge: true)
is set and these ENV vars are present.
Edited by Jessie Young