Geo Sites - Incorrect DataType for Container Repositories
What / Why
Follow up to #373303 (closed)
Related to !93690 (merged)
Related to !98466 (merged)
Container Repositories are not being registered as a separate Data Type in the Geo UI. This is due to the Replicator overriding the data_type_title
but not overriding the data_type
value to the new Data Type.
The UI must group the data types by their data_type
as the data_type_title
is internationalized.
Code in reference to the issue: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/replicators/geo/container_repository_replicator.rb#L44-50
Screenshot
Proposal
Properly update the Replicator for Container Repositories to the new data_type
=> container_repository
def data_type
'container_repository'
end
Risks
I am unsure if there was a reason to not update the data_type
. Worried about some potential generalization in the BE that may key off this value. From what I originally understood Container Repositories had a different replication strategy so we needed an entirely new data type. cc/ @mkozono @vsizov