Add pending deployment approvals to custom notification events
Problem
Based on some of our prior research in https://gitlab.com/gitlab-org/ux-research/-/issues/2070+, we learned users really want to be notified when a deployment has a pending approval. A few ideas around to-dos, slack integrations have been suggested, but potentially the easiest MVC would be allowing users to opt into email notifications from the custom notification settings.
Currently users are given the option to customize their notification settings on the project home page as well as in their user settings:
Example Modal |
---|
Potential Solution
- A good MVC may be just to add in pending deployments to this modal, so users can opt into email notifications when something needs an approval.
Technical proposal
Working off of 2eb9c962, add the ability to send notifications when a deployment requires approval. Note that these notifications should exist only within the EE codebase.
This includes building both HTML and plain text mailers that would exist in ee/app/views/notifiy/
As the notification settings are loaded dynamically, no changes to the custom notification modal should be necessary.
We can build this out behind a feature flag to assist in splitting the backend
and frontend work. Let's name it notify_deployment_approval
.
The HTML mailer template should be visually similar to
app/views/notify/pipeline_success_email.html.haml
.
What Success Looks Like
- ITBD