Update rspec files with corresponding feature categories for spec/services and spec/workers
Update 2023-03-17
Weith this issue we updated spec/services and spec/workers. We are now at 60%of all tests are updated.
We have good coverage on the tests that bring us the most value, slow tests and flaky tests.
We do not aim for having 100% coverage now, the remaining tests will be updated in time naturally
Summary
Continuation of #381801 (closed)
Update RSpec files with corresponding feature categories.
See docs.
Details
Adding here the list of RSpec files that should be updated with the feature_category_metadata.
The goal is to update all files with the best gues for the feature category we can do. I suspect in time the feature_category will be updated to be more accurate.
How?
- Pick a group of files and add your name near the list item.
- Update the files and related the MR to this issue. This snippet is useful
- For controllers, services and sidekiq workers we can use the feature_category defined in the files for the actions.
- Using files:
- We are doing our best to make a good guess about the feature categories, we are aware that this will not be perfect.
- Thick the checkbox when MR is merged.
- Celebrate
🎉
Why?
This information is added to flaky tests reports and from here we can automatically quarantine tests and create issues for the related feature and group owning the feature.
RSpec files that need to be updated:
-
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/benchmarks -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/bin -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/channels -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/commands -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/components -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/dependencies -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/docs_screenshots -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/experiments -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/finders -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/frontend -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/frontend_integration -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/graphql -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/haml_lint -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/helpers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/initializers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/lib -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/mailers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/metrics_server -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/models -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/policies -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/presenters -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/rack_servers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/routing -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/rubocop -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/scripts -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/serializers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/services @alinamihaila -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/sidekiq -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/sidekiq_cluster -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/spam -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/support_specs -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/tasks -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/tooling -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/uploaders -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/validators -
(https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/views -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/spec/workers
RSpec ee files that need to be updated:
-
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/components -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/config -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/db -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/elastic -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/elastic_integration -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/finders -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/frontend -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/frontend_integration -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/graphql -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/helpers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/initializers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/lib -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/mailers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/models -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/policies -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/presenters -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/replicators -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/routing -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/serializers -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/services @alinamihaila -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/tasks -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/uploaders -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/validators -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/views -
https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/workers