Never show Security Configuration Upgrade Banner within CE

Proposal

Never show this upgrade banner within CE. We do not want to hide this banner based on the hide_third_party_offers setting as this banner promotes GitLab Ultimate (trial) and not a third-party offer.

See comment

Original description

We run the Community Edition, by policy, and have hide_third_party_offers / "Do not display content for customer experience improvement and offers from third parties" set to true. Despite this, users have noticed an upsell in the security configuration for their projects:

It seems desirable for use cases like ours not to see this kind of thing. It aligns with my expectations of the setting in question that it would hide this behavior, and others like it. If that setting is ineffective, or if I'm mistaken about the meaning of "customer experience improvement" and it only covers material from literal third-parties, it would be helpful to have a bit more clarity about that in the interface.

(I'm fully aware that it is not in GitLab's interest to stop promoting paid features in the Community Edition, but I said I'd file a ticket upstream, so here I am.)

Thanks!

(Cross reference to issue as filed on Wikimedia Phabricator: T295453)

Implementation steps

Hide the upgrade banner on CE.

• move app/assets/javascripts/security_configuration/components/upgrade_banner.vue to ee/app/assets/javascripts/security_configuration/components/upgrade_banner.vue
• import the upgrade_banner.vue asynchronously and start import path with ee_component to make sure an empty component gets rendered when on CE in app/assets/javascripts/security_configuration/components/app.vue

Verification steps

As we cannot simulate CE in staging, part of the verification has to be done on local. @svedova opened Add ability to deploy CE of GitLab to the Revie... (#409834) • Unassigned to be able to test CE in the review app in the future.

Validate banner shows in EE

• On staging.gitlab.com, log in with stagingtest account in the Gitlab-QA vault in 1password. This account does not have an ultimate license
• Go to https://staging.gitlab.com/verification1/security-banner/-/security/configuration
• Verify that it shows the banner

Validate in CE (local)

• simulate CE by:
  • Create an env.runit file in the root of your GDK with the line containing export FOSS_ONLY=1
  • restart GDK: gdk restart rails && gdk restart webpack
• Go to /flightjs/Flight/-/security/configuration
• Validate that it does not show the banner

Undo CE simulation by commenting export FOSS_ONLY=1 and restarting GDK again.