Skip to content

Use non-DinD mode by default for Security Products

Problem to solve

We now have a working solution for non-DinD mode but this is currently an opt-in approach for SAST and Dependency Scanning.

Make sure everything is ready to switch in %13.0

Intended users

Further details

Currently DS_DISABLE_DIND and SAST_DISABLED_DIND are false by default. These are set in Dependency-Scanning.gitlab-ci.yml and SAST.gitlab-ci.yml, respectively.

Proposal

Permissions and Security

No change.

Documentation

Testing

Risks

  • If the QA for the legacy DinD setup is missing or incomplete, this might be leading to a regression in SAST and DS when running the DinD setup, which would affect old versions of GitLb.
  • If there's a discrepancy in project detection, a project might get new vulnerabilities users don't want, or lose vulnerabilities it used to have.
  • If there's a discrepancy in vulnerability tracking or merging, the vulnerabilities might change in the UI, and vulnerability feedback might be lost.

To be investigated:

What does success look like, and how can we measure that?

SAST and Dependency Scanning default to the setup where each scanner runs in its own CI job, and there's no Docker-in-Docker orchestrator anymore.

What is the type of buyer?

GitLab Ultimate

Links / references

Depreciation release post

Edited by Fabien Catteau