Cancel Merge When Pipeline Succeeds if it is blocked for too long
Problem
A recent master:broken was caused by a two-day old MWPS finally getting merged when all threads were resolved, becuase there had since been incompatible changes pushed to master
.
Paraphrasing #367898 (comment 1026907956):
- MR was created
- MWPS was set on 2022-07-12 12:06
- Pipeline failed, due to an unrelated master:broken
- master:broken was fixed
- A new pipeline was run, but a thread remained unresolved
- When the pipeline succeeded, the merge was blocked by the open thread
- Time passed
- "Resolve all threads" was set on 2022-07-14 14:30 (without realising MWPS was still set), and the MR was immediately merged, with the old (but green) pipeline.
Proposal
Merge When Pipeline Succeeds should be cancelled automatically (expire) when they are blocked for too long, perhaps just a day.
@stanhu
: At the very least, I think MWPS should be cancelled within a day, especially if no builds are running. Maybe there should be some automated notification that MWPS is stuck due to an unresolved thread?
Edited by James Heimbuck