Skip to content

multiple Icons on Hover for CodeQuality Inline Indicator

The codequality findings inline indicator needs to be enhanced to match the following design:

https://www.figma.com/proto/twTfCrCHgag9WYu1pWNbi0/Inline-security-notifications-in-the-MR?page-id=704%3A44017&node-id=721%3A63834&viewport=148%2C-56%2C0.25&scaling=min-zoom&starting-point-node-id=721%3A63834&show-proto-sidebar=1

demo
Screenshot_2022-06-03_at_11.08.08

Things to be implemented:

  1. Icon for each severity finding
  2. Hover effect as in design
  3. logic to display indicator if more than 3 findings

Things to be discussed:

  • What kind of GitLab UI element is the +2 indicator (Source) Do we need to build this?
  • Is this indicator (maybe with different Icons) meant to be used for other inline-findings as well? So it would potentially make sense to make this a reusable GitLabUI Component?
Edited by Jannik Lehmann