Geo - Technical Audit of `helpers/ee/geo_helper.rb`
What / Why
Recently an unused method in https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/helpers/ee/geo_helper.rb caused some confusion. This method was toggle_node_button
. However, I would imagine there are other methods as well in that file that are no longer being used.
We could do with a quick run through to clean up anything that has been left as artifacts from the SSF and Geo Sites UI 2.0 enhancements.
Proposal
- Audit https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/helpers/ee/geo_helper.rb
- Remove any unused methods
- Remove associated tests
- Run all pipelines to be sure we didn't wrench anything
Edited by Zack Cuddy