Geo Replication Details URL - Navigate to root route rather than first SSF replicable
What/Why
Follow up for !80106 (merged)
With the above MR we adjusted the web_geo_replication_details_url
to direct to the first SSF replicator rather than the root /replication
path. This causes some issues with the upcoming frontend logic and places you in the 3rd tab on the Replication UI which isn't an idea UX scenario. We are place on the 3rd tab because Projects and Designs are still hard coded on the _replication_nav.haml
.
The Frontend also would like to create links to each secondary replication view via the Replication Details list view on the /sites
page. To do this there needs to be a generic way to store the /replication
route so that we can add the replicable
as the last parameter in the URL to be navigated to. (ie ${web_geo_replication_details_url}/${replicable}
)
Proposal
- Update geo_replication_details_url to build the URL without the
replicable_name_plural
parameter - Handle the redirect in the router rather than the model here: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/config/routes/admin.rb#L55
- We could go to the first SSF replicable but I think we should direct to the Project replication view so that it goes to the first tab rather than the 3rd (at least until we get everything into SSF).
cc/ @cat I apologies for missing this when the above mentioned MR was merged. Curious on your thoughts here. Am I missing a technical reason to forcing the first replicable in the model?