List of container images reloads when sort criteria or sort order has changed
Problem
First discovered on Harbor Registry MR, but also exists in the Container Registry.
When changing the sort criteria or sort order, the number of image repositories goes into the skeleton loader mode. However, changing the sort order / criteria should have no bearing on how many image repositories there are.
Solution
Do not reload the number of image repositories when sort order is changed on the:
-
Harbor Registry -
Container Registry
Implementation guide
This is because the isLoading
computed property is shared between the registry-header
, tags-list
& cli-commands
components, for example container registry, which causes t
The fix involves having a separate loading reactive property which shows only on first request, once for the registry-header
and cli-commands
components. Subsequent requests like pagination, filters & sorting should trigger not trigger this new loading property.