Revert "Add setting to not display code diffs in MR review emails"
Per @phikai in !79229 (comment 836189318)
After discussion in the Code Review group, we're going to revert this change and wait on some additional feedback before proceeding with a setting like this.
This decision was not easy, and something we discussed at length. I'd like to thank @joe-snyder for the bias for action and the community contribution. It's great to see and we're excited to continue to collaborate on future issues!
Why Revert?
The Code Review group is currently engaged on a very similar issue related to uploads in which we debated the use of a setting. Ultimately, we believe that if organizations are setting projects to private, they have that expectation for all behavior of items that might reach users via notifications. Forcing organizations to find and then utilize a setting for this doesn't make sense when they've already implied this behavior by setting a project to private.
Can this be contributed without a setting?
At this time, we do not want to accept a contribution for similar functionality but without the setting. The reason for this is that we're in the middle of completing the other similar issue and want to take community feedback on that prior to compounding that pattern. We're also concerned about the lost diffs in emails as they wouldn't be recoverable if we did revert the setting-less behavior.
What are the next steps?
- We're going to revert this change so that it does not make it in the packaged %14.8 release and is removed from GitLab.com.
- When the authorization checks for images are released, we'll seek feedback on that change. We don't expect to roll that feature out widely until during %14.9 and it may extend beyond that.
- Pending feedback we'll open this issue back up for contributions with our desired set of requirements (setting/no-setting).