Make hideFlash behaviour consistent.
The following discussion from !18898 (closed) should be addressed:
-
@dennis started a discussion: (+3 comments) This is interesting, is this how we do it in other specs? I thought we would just do
expect(flashAlert).not.toBeVisible();
Problem
hideFlash
will either set the opacity of the flash element to 0, or completely remove the element - depending on whether the fadeTransition
parameter is passed through as true or false.
This contributes towards complicated / unclear testing and behaviour.
Suggestion
A standard, conformed outcome should result from calling hideFlash
- either set the element's opacity to 0 or remove the element.
Proposal
The flash element should be removed when calling hideFlash
.