Skip to content

CleanUpMigrateMergeRequestDiffCommitUsers fails on 14.5.2

Summary

gitlab-rake db:migrate fails on 20211012134316 CleanUpMigrateMergeRequestDiffCommitUsers DB migration because of undefined method author_name'`

Steps to reproduce

  1. Upgrade to GitLab 14.5.2, run
  2. Run gitlab-rake db:migrate

Example Project

Not project dependant

What is the current bug behavior?

gitlab-rake db:migrate fails and stops at 20211012134316 CleanUpMigrateMergeRequestDiffCommitUsers migration, leaving a bunch of non-executed DB migrations. I ended up doing all other pending migrations but this one

...
   up     20211012015903  Next traversal ids sibling function
   up     20211012051221  Add index btree namespaces traversal ids
   up     20211012091822  Add text limit to bulk imports source version
  down    20211012134316  Clean up migrate merge request diff commit users
   up     20211012143815  Remove merge request diff commit columns
   up     20211012155931  Remove schedule and status from pending alert escalations
   up     20211013014228  Add content validation endpoint to application settings
   up     20211013080714  Add network to user credit card validations
   up     20211013080715  Limit network on user credit card validations
   up     20211013080716  Index include network on user credit card validations
   up     20211013125341  Create index security ci builds on name and id parser features
   up     20211013192749  Add states into approval project rules
   up     20211015021114  Add merge commit template to project settings
   up     20211015024135  Add merge commit template limit to project settings
   up     20211018101034  Add tmp project id column to namespaces
   up     20211018101552  Add index to tmp project id column on namespaces table
   up     20211018101852  Add fk to tmp project id column on namespaces table
   up     20211018102252  Add index to group id column on webhooks table
   up     20211018123316  Remove not null constraint and default for public email
   up     20211018152654  Schedule remove duplicate vulnerabilities findings3
   up     20211018161447  Fix double entries in postgres index view
   up     20211019153615  Add state to merge request assignees
   up     20211020030948  Add runtime runner features to ci builds metadata
   up     20211020095357  Add group traversal id index
   up     20211021125908  Add sentry settings to application settings
   up     20211021131217  Add deployments environment id and ref index
   up     20211021134458  Add limits to sentry settings on application settings
   up     20211021140426  Remove geo upload deprecated fields
   up     20211021141930  Drop geo upload deleted events table
   up     20211022112202  Add cluster id location index to vulnerability occurrences
   up     20211022113000  Drop index security ci builds on name and id parser features broken
   up     20211022160154  Remove outdated fields from geo node status
   up     20211025103744  Add state id to vsa issue stage events
   up     20211025103758  Add state id to vsa merge request stage events
   up     20211026143238  Remove index releases on author
   up     20211027064021  Track deletions in ci runners
   up     20211027064156  Track deletions in chat names
   up     20211027112901  Drop index keys on expires at and before expiry notification undelivered
   up     20211027203950  Add updated index for dormant users
   up     20211027204011  Remove index for dormant users
   up     20211028085926  Add occurrence id id desc index to vulnerability occurrence pipelines
   up     20211028100303  Tmp index for delete issue merge request taggings records
   up     20211028100843  Delete issue merge request taggings records
   up     20211028123412  Add async index on events using btree created at
   up     20211028132247  Create packages npm metadata
   up     20211028155449  Schedule fix merge request diff commit users migration
   up     20211028212259  Add default to personal access tokens prefix
   up     20211029102822  Add open source plan
   up     20211031152417  Add indexes to issue stage events
   up     20211031154919  Add indexes to merge request stage events
   up     20211101132310  Add reindexing queue
   up     20211102103127  Add temp index to vulnerability occurrences
   up     20211102114802  Update vulnerability occurrences location
   up     20211103062728  Add with highest role minimal access to users statistics
   up     20211103162025  Add index on events using btree created at
   up     20211104012209  Add text limit to application settings content validation endpoint url
   up     20211104044453  Remove redundant events index
   up     20211105010101  Add archived column to deployments
   up     20211105125756  Add read at to dependency proxy manifests
   up     20211105125813  Add read at to dependency proxy blobs
   up     20211105135157  Drop ci build trace sections
   up     20211105160316  Create dotenv application limits
   up     20211105161404  Insert dotenv application limits
   up     20211108154510  Create pipeline triggers application limits
   up     20211108154841  Insert pipeline triggers application limits
   up     20211108203248  Update dependency proxy indexes with read at
   up     20211108211434  Remove index for resource group
   up     20211109100050  Add consume after to loose fk deleted records
   up     20211109101010  Support partition query in loose fk table
   up     20211109112454  Drop old loose fk deleted records index
   up     20211110010101  Add index on unarchived deployments
   up     20211110100050  Add has shimo to project settings
   up     20211112113300  Remove ci pipeline chat data fk on chat names
   up     20211112155416  Populate default value for personal access tokens prefix
   up     20211115151704  Add index on projects import type

What is the expected correct behavior?

gitlab-rake db:migrate completes successfully

Relevant logs and/or screenshots

[root@svmagit0000 ~]# gitlab-rake db:migrate
== 20211012134316 CleanUpMigrateMergeRequestDiffCommitUsers: migrating ========
-- 7 MigrateMergeRequestDiffCommitUsers are still pending
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

undefined method `author_name' for #<Gitlab::BackgroundMigration::MigrateMergeRequestDiffCommitUsers::MergeRequestDiffCommit:0x00007f6f42f8dca8>
Did you mean?  authored_date
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:120:in `block in get_data_to_update'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:65:in `block in each_row_to_migrate'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/pagination/keyset/iterator.rb:25:in `block in each_batch'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/pagination/keyset/iterator.rb:19:in `loop'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/pagination/keyset/iterator.rb:19:in `each_batch'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:65:in `each_row_to_migrate'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:119:in `get_data_to_update'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:87:in `perform'
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb:29:in `block in up'
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb:26:in `each'
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb:26:in `up'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/connection_proxy.rb:126:in `block in write_using_load_balancer'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/load_balancer.rb:112:in `block in read_write'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/load_balancer.rb:172:in `retry_with_backoff'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/load_balancer.rb:110:in `read_write'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/connection_proxy.rb:125:in `write_using_load_balancer'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/connection_proxy.rb:77:in `transaction'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database.rb:252:in `block in transaction'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database.rb:251:in `transaction'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/migrations/lock_retry_mixin.rb:31:in `ddl_transaction'
/opt/gitlab/embedded/bin/bundle:23:in `load'
/opt/gitlab/embedded/bin/bundle:23:in `<main>'

Caused by:
NoMethodError: undefined method `author_name' for #<Gitlab::BackgroundMigration::MigrateMergeRequestDiffCommitUsers::MergeRequestDiffCommit:0x00007f6f42f8dca8>
Did you mean?  authored_date
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:120:in `block in get_data_to_update'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:65:in `block in each_row_to_migrate'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/pagination/keyset/iterator.rb:25:in `block in each_batch'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/pagination/keyset/iterator.rb:19:in `loop'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/pagination/keyset/iterator.rb:19:in `each_batch'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:65:in `each_row_to_migrate'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:119:in `get_data_to_update'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb:87:in `perform'
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb:29:in `block in up'
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb:26:in `each'
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb:26:in `up'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/connection_proxy.rb:126:in `block in write_using_load_balancer'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/load_balancer.rb:112:in `block in read_write'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/load_balancer.rb:172:in `retry_with_backoff'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/load_balancer.rb:110:in `read_write'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/connection_proxy.rb:125:in `write_using_load_balancer'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/load_balancing/connection_proxy.rb:77:in `transaction'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database.rb:252:in `block in transaction'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database.rb:251:in `transaction'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/database/migrations/lock_retry_mixin.rb:31:in `ddl_transaction'
/opt/gitlab/embedded/bin/bundle:23:in `load'
/opt/gitlab/embedded/bin/bundle:23:in `<main>'
Tasks: TOP => db:migrate
(See full trace by running task with --trace)

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		CentOS 7.9.2009
Current User:	git
Using RVM:	no
Ruby Version:	2.7.5p203
Gem Version:	3.1.4
Bundler Version:2.1.4
Rake Version:	13.0.6
Redis Version:	6.0.16
Git Version:	2.33.1.
Sidekiq Version:6.2.2
Go Version:	unknown

GitLab information
Version:	14.5.2
Revision:	76ceea558aa
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	PostgreSQL
DB Version:	12.7
URL:		https://vip-gitlab.staging.nod.nuance.com
HTTP Clone URL:	https://vip-gitlab.staging.nod.nuance.com/some-group/some-project.git
SSH Clone URL:	git@vip-gitlab.staging.nod.nuance.com:some-group/some-project.git
Using LDAP:	yes
Using Omniauth:	yes
Omniauth Providers:

GitLab Shell
Version:	13.22.1
Repository storage paths:
- default: 	/var/opt/gitlab/git-data/repositories
GitLab Shell path:		/opt/gitlab/embedded/service/gitlab-shell
Git:		/opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...


Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 13.22.1 ? ... OK (13.22.1)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes (cluster/worker) ... 1/1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
User output sanitized. Found 100 users of 100 limit.


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Systemd unit files or init script exist? ... skipped (omnibus-gitlab has neither init script nor systemd units)
Systemd unit files or init script up-to-date? ... skipped (omnibus-gitlab has neither init script nor systemd units)
Projects have namespace: ...
21/1 ... yes
20/9 ... yes
20/13 ... yes
20/15 ... yes
29/17 ... yes
20/23 ... yes
21/24 ... yes
20/25 ... yes
20/26 ... yes
21/27 ... yes
76/34 ... yes
76/35 ... yes
39/36 ... yes
78/37 ... yes
78/38 ... yes
84/40 ... yes
90/41 ... yes
90/42 ... yes
90/43 ... yes
78/44 ... yes
90/45 ... yes
20/47 ... yes
96/48 ... yes
90/49 ... yes
98/50 ... yes
89/51 ... yes
62/54 ... yes
20/56 ... yes
103/62 ... yes
103/63 ... yes
103/64 ... yes
103/65 ... yes
104/66 ... yes
100/68 ... yes
90/70 ... yes
104/71 ... yes
78/72 ... yes
108/73 ... yes
115/74 ... yes
115/75 ... yes
62/76 ... yes
20/78 ... yes
115/79 ... yes
20/80 ... yes
90/82 ... yes
96/83 ... yes
90/84 ... yes
104/86 ... yes
90/87 ... yes
90/88 ... yes
115/90 ... yes
39/93 ... yes
76/95 ... yes
134/96 ... yes
39/97 ... yes
133/100 ... yes
133/101 ... yes
126/102 ... yes
137/103 ... yes
140/105 ... yes
143/107 ... yes
143/108 ... yes
60/109 ... yes
113/110 ... yes
146/112 ... yes
20/114 ... yes
78/115 ... yes
20/116 ... yes
20/117 ... yes
146/118 ... yes
113/119 ... yes
381/120 ... yes
96/126 ... yes
146/127 ... yes
152/128 ... yes
146/130 ... yes
146/131 ... yes
146/132 ... yes
138/134 ... yes
113/136 ... yes
96/137 ... yes
146/138 ... yes
146/139 ... yes
146/140 ... yes
159/141 ... yes
159/143 ... yes
165/146 ... yes
148/147 ... yes
146/148 ... yes
146/149 ... yes
146/150 ... yes
146/151 ... yes
146/152 ... yes
146/154 ... yes
146/156 ... yes
146/157 ... yes
146/158 ... yes
146/159 ... yes
146/160 ... yes
146/161 ... yes
146/162 ... yes
146/163 ... yes
146/166 ... yes
157/167 ... yes
146/169 ... yes
146/179 ... yes
146/180 ... yes
146/186 ... yes
146/188 ... yes
146/189 ... yes
146/194 ... yes
146/195 ... yes
146/198 ... yes
146/199 ... yes
146/201 ... yes
146/202 ... yes
146/203 ... yes
146/204 ... yes
11/206 ... yes
146/229 ... yes
146/230 ... yes
146/231 ... yes
133/233 ... yes
133/234 ... yes
167/235 ... yes
146/237 ... yes
146/238 ... yes
146/240 ... yes
113/241 ... yes
146/242 ... yes
146/243 ... yes
159/244 ... yes
179/245 ... yes
143/246 ... yes
165/247 ... yes
165/248 ... yes
143/249 ... yes
183/250 ... yes
146/251 ... yes
146/258 ... yes
146/259 ... yes
146/261 ... yes
146/262 ... yes
146/265 ... yes
20/266 ... yes
146/267 ... yes
204/268 ... yes
204/269 ... yes
176/270 ... yes
113/271 ... yes
90/272 ... yes
104/273 ... yes
113/274 ... yes
113/275 ... yes
20/276 ... yes
113/277 ... yes
113/278 ... yes
113/279 ... yes
213/280 ... yes
213/281 ... yes
213/282 ... yes
146/283 ... yes
133/284 ... yes
179/285 ... yes
179/286 ... yes
179/287 ... yes
213/288 ... yes
74/289 ... yes
74/290 ... yes
96/295 ... yes
217/296 ... yes
217/297 ... yes
213/298 ... yes
217/299 ... yes
220/300 ... yes
221/301 ... yes
221/302 ... yes
221/303 ... yes
76/304 ... yes
213/305 ... yes
213/306 ... yes
146/307 ... yes
146/308 ... yes
213/309 ... yes
133/310 ... yes
213/311 ... yes
221/312 ... yes
234/314 ... yes
221/315 ... yes
213/316 ... yes
217/317 ... yes
232/318 ... yes
217/319 ... yes
232/321 ... yes
146/322 ... yes
115/323 ... yes
137/325 ... yes
238/326 ... yes
146/327 ... yes
146/328 ... yes
238/332 ... yes
232/333 ... yes
192/336 ... yes
217/337 ... yes
213/342 ... yes
213/343 ... yes
232/345 ... yes
213/347 ... yes
213/348 ... yes
246/350 ... yes
246/351 ... yes
213/352 ... yes
115/353 ... yes
90/354 ... yes
204/355 ... yes
204/356 ... yes
192/358 ... yes
146/360 ... yes
146/361 ... yes
146/362 ... yes
146/363 ... yes
146/364 ... yes
146/365 ... yes
106/367 ... yes
192/368 ... yes
251/369 ... yes
251/370 ... yes
251/371 ... yes
232/372 ... yes
213/374 ... yes
251/375 ... yes
251/376 ... yes
251/377 ... yes
213/379 ... yes
115/380 ... yes
20/383 ... yes
204/384 ... yes
106/385 ... yes
106/386 ... yes
90/387 ... yes
90/388 ... yes
260/389 ... yes
90/393 ... yes
213/394 ... yes
265/395 ... yes
90/396 ... yes
510/397 ... yes
266/398 ... yes
266/399 ... yes
266/400 ... yes
266/401 ... yes
510/402 ... yes
510/403 ... yes
510/404 ... yes
510/405 ... yes
146/406 ... yes
267/407 ... yes
213/409 ... yes
511/411 ... yes
213/412 ... yes
213/413 ... yes
213/414 ... yes
115/415 ... yes
90/416 ... yes
510/417 ... yes
510/418 ... yes
213/419 ... yes
143/422 ... yes
275/424 ... yes
213/425 ... yes
275/426 ... yes
281/430 ... yes
281/432 ... yes
280/433 ... yes
275/434 ... yes
275/435 ... yes
265/436 ... yes
275/437 ... yes
159/438 ... yes
232/439 ... yes
213/440 ... yes
291/443 ... yes
281/444 ... yes
192/445 ... yes
292/446 ... yes
294/447 ... yes
295/448 ... yes
292/449 ... yes
106/452 ... yes
90/453 ... yes
300/454 ... yes
275/455 ... yes
275/456 ... yes
213/457 ... yes
300/458 ... yes
300/459 ... yes
275/460 ... yes
113/463 ... yes
213/467 ... yes
292/468 ... yes
292/469 ... yes
113/471 ... yes
267/473 ... yes
281/476 ... yes
281/478 ... yes
281/479 ... yes
281/480 ... yes
308/505 ... yes
308/506 ... yes
275/517 ... yes
232/521 ... yes
317/522 ... yes
213/525 ... yes
280/528 ... yes
213/529 ... yes
213/530 ... yes
275/533 ... yes
331/534 ... yes
213/535 ... yes
317/536 ... yes
62/539 ... yes
20/540 ... yes
213/542 ... yes
338/543 ... yes
322/546 ... yes
317/547 ... yes
259/548 ... yes
332/549 ... yes
213/550 ... yes
146/551 ... yes
275/552 ... yes
275/553 ... yes
357/554 ... yes
146/555 ... yes
213/556 ... yes
113/557 ... yes
358/558 ... yes
76/560 ... yes
333/561 ... yes
213/562 ... yes
359/563 ... yes
332/564 ... yes
361/565 ... yes
361/566 ... yes
361/567 ... yes
280/568 ... yes
331/569 ... yes
337/570 ... yes
337/571 ... yes
294/572 ... yes
304/573 ... yes
510/574 ... yes
510/575 ... yes
213/576 ... yes
146/578 ... yes
213/579 ... yes
213/585 ... yes
213/586 ... yes
213/587 ... yes
102/588 ... yes
356/589 ... yes
367/590 ... yes
275/591 ... yes
367/592 ... yes
213/593 ... yes
370/594 ... yes
317/595 ... yes
213/596 ... yes
213/619 ... yes
426/631 ... yes
152/716 ... yes
213/740 ... yes
267/741 ... yes
467/743 ... yes
146/745 ... yes
146/746 ... yes
146/747 ... yes
146/748 ... yes
146/749 ... yes
146/750 ... yes
76/751 ... yes
472/753 ... yes
470/755 ... yes
466/756 ... yes
466/757 ... yes
467/758 ... yes
467/759 ... yes
467/760 ... yes
467/761 ... yes
467/762 ... yes
466/763 ... yes
475/764 ... yes
281/795 ... yes
146/800 ... yes
90/801 ... yes
511/802 ... yes
264/804 ... yes
262/806 ... yes
373/808 ... yes
373/809 ... yes
331/810 ... yes
506/813 ... yes
506/814 ... yes
506/815 ... yes
506/816 ... yes
506/817 ... yes
506/818 ... yes
506/819 ... yes
506/820 ... yes
322/822 ... yes
275/823 ... yes
527/824 ... yes
528/825 ... yes
374/826 ... yes
275/827 ... yes
533/828 ... yes
533/829 ... yes
534/830 ... yes
534/831 ... yes
532/832 ... yes
532/833 ... yes
531/834 ... yes
522/841 ... yes
275/842 ... yes
370/843 ... yes
213/844 ... yes
506/845 ... yes
528/846 ... yes
521/847 ... yes
275/850 ... yes
110/851 ... yes
374/852 ... yes
506/853 ... yes
506/855 ... yes
506/856 ... yes
76/857 ... yes
113/858 ... yes
113/859 ... yes
275/860 ... yes
275/861 ... yes
522/863 ... yes
300/864 ... yes
275/865 ... yes
213/870 ... yes
374/871 ... yes
522/872 ... yes
146/873 ... yes
322/874 ... yes
213/875 ... yes
213/876 ... yes
213/877 ... yes
522/884 ... yes
113/885 ... yes
558/886 ... yes
558/887 ... yes
558/888 ... yes
558/889 ... yes
511/893 ... yes
511/894 ... yes
295/895 ... yes
530/896 ... yes
530/897 ... yes
506/898 ... yes
522/899 ... yes
522/900 ... yes
522/901 ... yes
521/902 ... yes
275/903 ... yes
544/904 ... yes
560/905 ... yes
473/906 ... yes
473/907 ... yes
113/908 ... yes
566/909 ... yes
568/910 ... yes
568/911 ... yes
568/912 ... yes
568/913 ... yes
275/914 ... yes
275/915 ... yes
471/916 ... yes
471/917 ... yes
573/918 ... yes
521/919 ... yes
576/920 ... yes
576/921 ... yes
577/922 ... yes
521/923 ... yes
332/928 ... yes
281/929 ... yes
308/930 ... yes
308/931 ... yes
275/934 ... yes
583/935 ... yes
583/936 ... yes
353/939 ... yes
113/940 ... yes
113/941 ... yes
544/942 ... yes
366/943 ... yes
521/944 ... yes
475/945 ... yes
275/946 ... yes
275/947 ... yes
331/948 ... yes
275/949 ... yes
294/950 ... yes
522/951 ... yes
275/952 ... yes
580/953 ... yes
510/954 ... yes
510/955 ... yes
275/956 ... yes
601/957 ... yes
506/958 ... yes
179/959 ... yes
90/960 ... yes
106/961 ... yes
595/962 ... yes
275/963 ... yes
607/964 ... yes
607/965 ... yes
275/966 ... yes
275/967 ... yes
353/968 ... yes
304/969 ... yes
521/972 ... yes
551/974 ... yes
304/975 ... yes
304/976 ... yes
580/977 ... yes
275/978 ... yes
577/979 ... yes
217/980 ... yes
304/981 ... yes
304/982 ... yes
461/983 ... yes
522/984 ... yes
601/985 ... yes
304/986 ... yes
304/987 ... yes
470/988 ... yes
633/989 ... yes
633/990 ... yes
Redis version >= 5.0.0? ... yes
Ruby version >= 2.7.2 ? ... yes (2.7.5)
Git version >= 2.33.0 ? ... yes (2.33.1)
Git user has default SSH configuration? ... yes
Active users: ... 290
Is authorized keys file accessible? ... yes
GitLab configured to store new projects in hashed storage? ... yes
All projects are in hashed storage? ... yes


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished

Diagnosis

The commit in question was 9800171f. The migration files involved are :

  • db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb
  • db/post_migrate/20211012143815_remove_merge_request_diff_commit_columns.rb

Due to #346341 (closed), 20211012134316_clean_up_migrate_merge_request_diff_commit_users was skipped to allow other migrations to run, including 20211012143815_remove_merge_request_diff_commit_columns. This meant that columns integral to the former was lost.

Workaround, potential

Potentially #347392 (comment 1053177051)

Possible fixes

Edited by Thong Kuah