Server hook custom error messages not shown when merging MR
Summary
Probably related to #342122 (closed)?
When using custom server hook error messages, the messages output with "GL-HOOK-ERR" are no longer shown when merging Merge Requests.
Steps to reproduce
- Create new project
- add custom hook that adds a message:
#!/bin/bash
echo 'GL-HOOK-ERR: Error!'
exit 1
- Create a merge request for that repository and merge it
What is the current bug behavior?
The merge is denied but the error is not shown:
What is the expected correct behavior?
The message output with GL-HOOK-ERR should be displayed
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.7.4p191 Gem Version: 3.1.4 Bundler Version:2.1.4 Rake Version: 13.0.6 Redis Version: 6.0.14 Git Version: 2.33.0. Sidekiq Version:5.2.9 Go Version: unknown GitLab information Version: 14.3.2 Revision: 92acfb1b8a9 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 12.7 URL: https://srvgit01.ads.abit.de HTTP Clone URL: https://srvgit01.ads.abit.de/some-group/some-project.git SSH Clone URL: ssh://git@srvgit01.ads.abit.de:1022/some-group/some-project.git Using LDAP: yes Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 13.21.1 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 13.21.1 ? ... OK (13.21.1) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes (cluster/worker) ... 1/1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: ldapmain not verifying SSL hostname of LDAPS server '10.100.1.1:636' LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) User output sanitized. Found 71 users of 100 limit.
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 12/16 ... yes 13/17 ... yes 11/19 ... yes 4/21 ... yes 4/22 ... yes 17/23 ... yes 17/24 ... yes 17/25 ... yes 13/28 ... yes 13/30 ... yes 13/31 ... yes 13/32 ... yes 13/33 ... yes 13/34 ... yes 13/35 ... yes 13/36 ... yes 13/37 ... yes 13/38 ... yes 13/39 ... yes 13/40 ... yes 13/41 ... yes 13/42 ... yes 13/43 ... yes 13/44 ... yes 13/45 ... yes 13/46 ... yes 13/47 ... yes 13/48 ... yes 13/50 ... yes 13/51 ... yes 13/52 ... yes 13/53 ... yes 13/54 ... yes 12/55 ... yes 26/56 ... yes 32/69 ... yes 20/72 ... yes 24/74 ... yes 11/75 ... yes 11/77 ... yes 4/78 ... yes 11/79 ... yes 11/81 ... yes 11/82 ... yes 11/86 ... yes 35/87 ... yes 13/90 ... yes 22/91 ... yes 35/92 ... yes 42/93 ... yes 8/94 ... yes 11/95 ... yes 11/96 ... yes 11/97 ... yes 11/98 ... yes 11/100 ... yes 72/101 ... yes 72/102 ... yes 35/103 ... yes 37/105 ... yes 82/106 ... yes 35/107 ... yes 8/108 ... yes 11/109 ... yes 79/110 ... yes 78/111 ... yes 78/112 ... yes 78/114 ... yes 78/115 ... yes 82/117 ... yes 11/118 ... yes 35/122 ... yes 8/123 ... yes 35/124 ... yes 13/131 ... yes 77/132 ... yes 83/133 ... yes 8/135 ... yes 85/136 ... yes 85/137 ... yes 82/138 ... yes 83/139 ... yes 93/140 ... yes 93/141 ... yes 93/142 ... yes 78/143 ... yes 35/144 ... yes 77/145 ... yes 4/146 ... yes 83/147 ... yes 11/148 ... yes 4/151 ... yes 45/152 ... yes 8/153 ... yes 13/154 ... yes 8/155 ... yes 8/156 ... yes 79/157 ... yes 79/159 ... yes 82/160 ... yes 13/161 ... yes 78/162 ... yes 8/163 ... yes 8/164 ... yes 78/165 ... yes 8/166 ... yes 105/167 ... yes 105/168 ... yes 11/170 ... yes 105/171 ... yes 8/172 ... yes 107/173 ... yes 107/174 ... yes 37/175 ... yes 83/177 ... yes 78/178 ... yes 105/179 ... yes 82/180 ... yes 8/181 ... yes 105/182 ... yes 8/183 ... yes 8/184 ... yes 109/185 ... yes 109/186 ... yes 109/187 ... yes 110/189 ... yes 110/190 ... yes 109/191 ... yes 109/192 ... yes 109/193 ... yes 109/194 ... yes 8/195 ... yes 123/196 ... yes 106/197 ... yes 106/202 ... yes 106/203 ... yes 105/204 ... yes 77/205 ... yes 105/206 ... yes 8/207 ... yes 37/208 ... yes 13/209 ... yes 107/210 ... yes 123/211 ... yes 123/212 ... yes 123/213 ... yes 123/214 ... yes 124/215 ... yes 124/216 ... yes 124/217 ... yes 8/218 ... yes 8/219 ... yes 8/220 ... yes 13/221 ... yes 127/222 ... yes 77/223 ... yes 83/224 ... yes 124/225 ... yes 8/226 ... yes Redis version >= 5.0.0? ... yes Ruby version >= 2.7.2 ? ... yes (2.7.4) Git version >= 2.31.0 ? ... yes (2.33.0) Git user has default SSH configuration? ... yes Active users: ... 70 Is authorized keys file accessible? ... yes GitLab configured to store new projects in hashed storage? ... yes All projects are in hashed storage? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished