GL-HOOK-ERR from custom hooks not reported in REST API
Summary
When making commits via the REST API (POST /projects/:id/repository/files/:file_path
OR POST /projects/:id/repository/commits
) errors from a custom hook a no longer reported in the json response.
This happens for both 14.3.0 and 14.3.1 - all previous versions were OK. Regular commits via git cli are not affected, those still properly display the correct error message.
Steps to reproduce
- Create a custom gitlab hook in
/usr/local/share/gitlab/hooks/
:
#!/opt/gitlab/embedded/bin/python3
# -*- coding: utf-8 -*-
import sys
# Does not matter if printed to stdout via print(...) or to stderr
sys.stderr.write("GL-HOOK-ERR: you shall not pass\n")
sys.exit(1)
- Create an empty project
- POST to
/projects/:id/repository/files/README.md
:
{
"branch": "main",
"author_email": "test_user@example.com",
"author_name": "Firstname Lastname",
"content": "some content",
"commit_message": "create newfile"
}
Example Project
What is the current bug behavior?
You receive a 400 with this response body:
{'message': ''}
What is the expected correct behavior?
You should receive a 400 with this response body:
{'message': 'you shall not pass'}
Relevant logs and/or screenshots
Results of GitLab environment info
This is NOT or productive system, but the docker image is started locally to see if our test-suite accepts all relevant use-cases for a new GitLab version.
Expand for output related to GitLab environment info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 2.7.4p191 Gem Version: 3.1.4 Bundler Version:2.1.4 Rake Version: 13.0.6 Redis Version: 6.0.14 Git Version: 2.33.0. Sidekiq Version:5.2.9 Go Version: unknown GitLab information Version: 14.3.0-ee Revision: dec73e99fdd Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 12.7 URL: http://gitlab-ce HTTP Clone URL: http://gitlab-ce/some-group/some-project.git SSH Clone URL: ssh://git@gitlab-ce/some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 13.21.0 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 13.21.0 ? ... OK (13.21.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes (cluster/worker) ... 1/1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet) Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/1 ... yes 1/2 ... yes 1/3 ... yes 1/4 ... yes 1/5 ... yes 1/6 ... yes 1/7 ... yes 1/8 ... yes 1/9 ... yes 1/10 ... yes 1/11 ... yes 1/12 ... yes 1/13 ... yes 1/14 ... yes 1/15 ... yes 1/16 ... yes 1/17 ... yes Redis version >= 5.0.0? ... yes Ruby version >= 2.7.2 ? ... yes (2.7.4) Git version >= 2.31.0 ? ... yes (2.33.0) Git user has default SSH configuration? ... yes Active users: ... 1 Is authorized keys file accessible? ... yes GitLab configured to store new projects in hashed storage? ... yes All projects are in hashed storage? ... yes Elasticsearch version 7.x (6.4 - 6.x deprecated to be removed in 13.8)? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished