Follow-up from "Skip Product Intelligence review for growth experiments MRs"
The following discussion from !70907 (merged) should be addressed:
-
@rymai started a discussion: (+1 comment) question (non-blocking): Was there a reason to have this specific file detection logic instead of relying on
project_helper.changes_by_category
? I think we could move the patterns to https://gitlab.com/gitlab-org/gitlab/-/blob/16903a6c6af215ea0ff07d9549de37cd5439e96b/tooling/danger/project_helper.rb#L36-141 and useproduct_intelligence_paths_to_review = project_helper.changes_by_category[:product_intelligence]
indanger/product_intelligence/Dangerfile
instead ofmatching_changed_files = product_intelligence.matching_changed_files
.This can be done in a follow-up.
Summary
Product intelligence review was initially only a warning.
Later we added the product_intelligence
category and added the review in Danger roullete.
We can now move all logic for matching the files in https://gitlab.com/gitlab-org/gitlab/-/blob/16903a6c6af215ea0ff07d9549de37cd5439e96b/tooling/danger/project_helper.rb#L36-141 remove customer logic from Tooling::Danger::ProductIntelligence