Recommend integrations changes receive an approval from the integrations team
About
~"group::integrations" are responsible for the performance and security of code marked category: integrations
.
The quality of our codebase affects the group with regards to:
- Error budgets.
- Feature change locks.
Category:Integrations codebase is reasonably unique in that other groups can consider themselves owners of certain integrations.
To align with our responsibility to the category, we need more oversight into the quality of integrations code contributed.
As a single data point of the problem: when I authored the Confluence integration !36262 (merged) as part of Create:Knowledge, I was unaware of an integrations group (ecosystem, then), or that another team might have interest in new integrations code. The MR received the required number of approvals by members of Knowledge and Stability. The MR was very simple, but Knowledge had extensive plans to expand it &3629.
Proposal
Merge requests that touch integrations code should receive at least one approval from an integrations team member, like how a product intelligence review is recommended by GitLab Bot through Danger
(see https://gitlab.com/gitlab-org/gitlab-dangerfiles/-/merge_requests/25 and tooling/danger/project_helper.rb
.
This would be recommended but not enforced (similar to product intelligence).
What might we review?
We can use git history to get a sense of changes authored outside of the integrations team to our integrations model code if we look at the (old) app/models/project_services
directory.
There’s a recent flurry of documentation-related changes, but this was an anomaly while there was a documentation drive. We go back to around March 2021 to get a better look.
Notes:
- Some of these may have been reviewed by integrations team members.
- These don't represent "dangerous" changes, but just the frequency and kind of contributions.
- This is just one directory.
Changes ~6 months-worth:
- March 2021: !57434 (merged)
- Feb 2021: !53534 (merged)
- Jan 2021: 94c62315
- Jan 2021: !51908 (merged)
- Jan 2021: !50794 (merged)
- Dec 2020: !50030 (merged)
- Nov 2020: 22504bd3
- Nov 2020: bfb73335
- Oct 2020: 7e70ed4c
There were a few changes during that period that would probably constitute noise 611071d9 92db697a 0da7697f c938349f.