jira integration: Password cannot be blank error when switching to default settings
Summary
Unable to switch from custom to default settings for JIRA Integration
Steps to reproduce
- Setup jira integration for the whole instance
- Setup jira integration for a project by chosing custom settings (actually most of my projects have existing configs based on service templates where the password field could be left empty and it would inherit the password from the service template)
- Now choose "default settings"
- Observe you cannot enter a password as the form is completely disabled because we are inheriting from default settings
- Press Save.
- Observe "Password cannot be blank" error
What is the current bug behavior?
Password cannot be blank error
What is the expected correct behavior?
When switching from "custom settings" to "default settings" Gitlab should not flag a missing JIRA credential as an error.
Most project maintainers don't know the JIRA credentials. Having the JIRA credentials in a central location is one of the use cases for using the "default settings".
Relevant logs and/or screenshots
Output of checks
All green.
Results of GitLab environment info
Omnibus 14.2.3
Results of GitLab application Check
All green
Possible fixes
I don't know gitlabs codebase nor Ruby, but might be in here: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/integrations/jira.rb or possible higher up in the project integrations framework that validates forms.