Skip to content

Alert note with email participants is incompatible with confidential notes in service desk

Summary

We were evaluating the service desk again if it contains all the necessary features for us to migrate from Zendesk. While testing we found out that the alert note below the comment field is incompatible with the confidential notes feature flag.

Steps to reproduce

  1. Activate service desk for a project
  2. Activate the confidential notes feature Feature.enable(:confidential_notes)
  3. Send an email as a customer to the project service desk email
  4. Respond to the issue with a public comment. Alert note says customer email ... will be informed. 👍
  5. Respond to the issue with a confidential comment by ticking the checkmark.
    • Alert also says customer email ... will be informed. 👎
    • However, the customer will not receive the email. So the issue is only in the UI 👍

What is the current bug behavior?

Responding to the issue with a confidential comment. Alert also says customer email ... will be informed. However, the customer will not receive the email, which is correct.

What is the expected correct behavior?

The alert note should be hidden or having a text that indicates that no public participant will receive a notification.

Relevant logs and/or screenshots

Correct behavior public

Incorrect behavior confidential

Output of checks

Expand for output related to GitLab environment info 

GitLab information
Version:	14.1.2-ee
Revision:	0bf9b154ab4
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	PostgreSQL
DB Version:	12.6
URL:		https://xxx
HTTP Clone URL:	https://xxx/some-group/some-project.git
SSH Clone URL:	git@xxx:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: gitlab

Possible fixes

The issue was most likely introduced by this MR without compatibility for the feature flag.