Geo: Container repositories progress bar shows old counts when replication becomes disabled
On staging.gitlab.com, container repositories replication is disabled, but /admin/geo/nodes
shows 25 container repositories queued:
The total count was populated with 25 at some point, perhaps because replication was enabled at some point.
Possible fix 1
Probably the quickest fix would be to set the total count to nil
when replication is disabled, in https://gitlab.com/gitlab-org/gitlab/-/blob/06b79431987b75c4997d3131b4602a61d2a8b5c3/ee/app/models/geo_node_status.rb#L504 (and also other similar methods) since it would cause the progress bar to show the unavailableLabel
(Nothing to synchronize
) https://gitlab.com/gitlab-org/gitlab/-/blob/baa6067d893fa09aaa80da0d16f60f823041b2e8/app/assets/javascripts/vue_shared/components/stacked_progress_bar.vue#L112.
Possible fix 2
Ideally, I think we would show See comments. The easy backend fix makes the most sense since this doesn't impact SSF.Replication disabled
. It looks like we used to say Synchronization disabled
in the old UI !28963 (merged). But this is probably more effort than possible fix 1, with small additional benefit.