Dogfood code quality feature
GitLab offers a code quality feature in code verification https://docs.gitlab.com/ee/user/project/merge_requests/code_quality.html.
This feature is currently enabled in GitLab development pipeline and results are reported back in MRs, however it doesn't seem being leveraged in MR reviews currently. An example of the report is below !16775 (merged)
In the spirit of dogfooding, we want to identify how to leverage this feature to enhance code quality. Below is a non-exhaustive list of decisions to make for enabling dogfooding of code quality -
- Items to check (if customizable)
- Level of checks (if customizable)
- Acceptance criteria, e.g. -
- What warning must be resolved
- What warning can be accepted
- How the scores are referenced
- Execution approach, e.g. -
- Soft enforcement by clearly stating requirements in https://gitlab.com/gitlab-org/gitlab-foss/blob/master/doc/development/contributing/merge_request_workflow.md#definition-of-done
-
Hard enforcement by disabling
Merge
button until unacceptable warnings are resolved - Or, both of above
- ...
@gitlab-org/frontend/frontend-managers @gitlab-com/backend-managers Suggestions and opinions are welcome! Please pass along to whoever may be interested in this topic.
Edited by Chun Du