Skip to content

Creating an application dumps user to an inescapable screen.

Problem

When you create an application, there is no way to proceed past the success screen unless you close the window or navigate away from it. This is not good UX. This functionally is a dead end in the process.

1

empty state create new application success
Screen_Shot_2021-06-30_at_12.39.36_PM Screen_Shot_2021-06-30_at_12.40.10_PM Screen_Shot_2021-06-30_at_12.40.22_PM

Proposals

  • The Edit and Destroy buttons should be changed priorities and a new button should be added to allow the user to continue to the application list.
  • Rename Destroy to Delete

Frame_8

Implementation plan

  1. Create two new methods in app/controllers/concerns/oauth_applications.rb (might adjust naming when implementing)
def set_redis_created
  Gitlab::Redis::SharedState.with do |redis|
    redis.set(CREATED_REDIS_KEY, Gitlab::Redis::Boolean.encode(true))
  end
end

def get_redis_created
  Gitlab::Redis::SharedState.with do |redis|
    created = redis.get(CREATED_REDIS_KEY)
    redis.del(CREATED_REDIS_KEY)

    created.nil? ? false : Gitlab::Redis::Boolean.decode(created)
  end
end
  1. Call set_redis_created in create action of the following controllers:

  2. Add @created = get_redis_created to the show action in the following controllers

  3. Check for @created instance variable in app/views/shared/doorkeeper/applications/_show.html.haml#L42. Render a Continue button if it exists.

Edited by Daniel Mora