Creating an application dumps user to an inescapable screen.
Problem
When you create an application, there is no way to proceed past the success screen unless you close the window or navigate away from it. This is not good UX. This functionally is a dead end in the process.
empty state | create new application | success |
---|---|---|
Proposals
- The
Edit
andDestroy
buttons should be changed priorities and a new button should be added to allow the user to continue to the application list. - Rename
Destroy
toDelete
Implementation plan
- Create two new methods in app/controllers/concerns/oauth_applications.rb (might adjust naming when implementing)
def set_redis_created
Gitlab::Redis::SharedState.with do |redis|
redis.set(CREATED_REDIS_KEY, Gitlab::Redis::Boolean.encode(true))
end
end
def get_redis_created
Gitlab::Redis::SharedState.with do |redis|
created = redis.get(CREATED_REDIS_KEY)
redis.del(CREATED_REDIS_KEY)
created.nil? ? false : Gitlab::Redis::Boolean.decode(created)
end
end
-
Call
set_redis_created
increate
action of the following controllers: -
Add
@created = get_redis_created
to theshow
action in the following controllers -
Check for
@created
instance variable in app/views/shared/doorkeeper/applications/_show.html.haml#L42. Render aContinue
button if it exists.
Edited by Daniel Mora