Enable and remove pages_limit_entries_count feature flag
Summary
This issue is to rollout pages file count limits on production,
that is currently behind the pages_limit_entries_count
feature flag.
It limits the number of files per pages deployments.
We've already warned users exceeding this number: https://gitlab.com/gitlab-com/support/internal-requests/-/issues/8383
Owners
- Team: ~"group::release"
- Most appropriate slack channel to reach out to:
#s_release
- Best individual to reach out to: @vshushlin
- PM: @kbychu
Stakeholders
The Rollout Plan
- Test on personal project
- Enable for everyone(there are only a few users and we've already warned them), FF was introduced to control the date when we enforce this limit
Testing Groups/Projects/Users
-
vshushlin/pages-files
project
Expectations
What might happen if this goes wrong?
Some users may complain about this limit
What can we monitor to detect problems with this?
Rollout Steps
Global rollout on production
-
Enable for everyone
Release the feature
We don't need this FF on self-manage, as users can manage this limit by hand and it's documented: https://docs.gitlab.com/ee/administration/instance_limits.html#number-of-files-per-gitlab-pages-web-site
-
Create a merge request to remove <feature-flag-name>
feature flag. Ask for review and merge it.-
Remove all references to the feature flag from the codebase. -
Remove the YAML definitions for the feature from the repository. -
Create a changelog entry.
-
-
Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post. -
/chatops run auto_deploy status <merge-commit-of-cleanup-mr>
-
-
Close the feature issue to indicate the feature will be released in the current milestone. -
Clean up the feature flag from all environments by running these chatops command in #production
channel:-
/chatops run feature delete <feature-flag-name> --dev
-
/chatops run feature delete <feature-flag-name> --staging
-
/chatops run feature delete <feature-flag-name>
-
-
Close this rollout issue.
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set pages_limit_entries_count false
Edited by Vladimir Shushlin