For issues with no closed events, use the issue closed_at date for burndown event
Summary
In burndown charts, issues with no closed events are currently treated as though they were closed at the start of the milestone. This is a legacy behaviour from before the rendering code was refactored and we should change it to use the issue's closed_at
attribute as the single source of truth.
Improvements
- Improve the overall accuracy of the burndown chart
- Remove the need for inaccurate burndown chart warning, as seen in the screenshot in this comment
Risks
- None that I can think of right now
Involved components
- https://gitlab.com/gitlab-org/gitlab/blob/51d037e4480a996b4aaacce74222aa2399d2fccc/ee/app/models/burndown.rb#L107-116
- https://gitlab.com/gitlab-org/gitlab/blob/727a2a862abd4c9c8e1b245f7508e556a0ba431d/ee/app/helpers/ee/milestones_helper.rb#L32
- https://gitlab.com/gitlab-org/gitlab/blob/41f3809d8a192910c87bda63b35140be1ba43397/doc/user/project/milestones/burndown_charts.md#L68
Optional: Intended side effects
Optional: Missing test coverage
Edited by Wei-Meng Lee