Follow-up from "Enable EE registration features for UsagePing"
The following discussion from !64003 (merged) should be addressed:
-
@alberts-gitlab started a discussion: (+3 comments) @rkadam3 What do you think of including
License.features_with_usage_ping.include?(:feature)
in the implementation ofLicense.feature_available?(:feature)
, so that if new features are added toFEATURES_WITH_USAGE_PING
, existing feature available checks will not need to be changed?Then from the test perspective, the existing
stub_licensed_features
can remain unchanged, and we don't need to test explicitly for enabling usage ping. It would be tested from the behaviour ofLicenase.feature_available?
instead.