Permissions levels are not clear when adding namespaces
The GitLab for Jira Cloud app can only link groups. It works for top-level or subgroups. It does not work for projects or personal namespases.
Problem
When wanting to link a group (or subgroup) in the GitLab for Jira Cloud app, one must have Owner
or Maintainer
role for a group.
The term "namespace" is confusing and should be changed to "group".
Current error state |
---|
![]() |
Feedback:
Proposal
- Remove the term "namespace" and only use the term "groups".
- Describe which roles are needed in order to see a namespace.
Has permission | NO permission |
---|---|
![]() |
![]() |
Copy
Link groups
Search...
No groups found
Only groups you have at least the Maintainer role for appear here.
See comment: #225803[Connect-app-MVC1-01.png] (comment 583625114)
Not seeing your Groups?
Make sure you have "Owner" or "Maintainer" permissions set at that group level. (see comment).
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Libor Vanc added to epic &4354 (closed)
added to epic &4354 (closed)
- Libor Vanc changed the description
Compare with previous version changed the description
- Libor Vanc added JiraGitLab for Jira Cloud app Technical Writing UX devopscreate groupecosystem [DEPRECATED] + 1 deleted label
added JiraGitLab for Jira Cloud app Technical Writing UX devopscreate groupecosystem [DEPRECATED] + 1 deleted label
- 🤖 GitLab Bot 🤖 added sectiondev label
added sectiondev label
- Libor Vanc mentioned in design management/design #225803[Connect-app-MVC1-01.png]
mentioned in design management/design #225803[Connect-app-MVC1-01.png]
- Libor Vanc added priority3 severity4 labels
- Libor Vanc added workflowready for design label
added workflowready for design label
- Libor Vanc changed the description
Compare with previous version changed the description
- Libor Vanc changed the description
Compare with previous version changed the description
- Libor Vanc changed the description
Compare with previous version changed the description
- Libor Vanc added UI polish UI text labels
- Libor Vanc assigned to @lvanc
assigned to @lvanc
- Arturo Herrero added IntegrationJira label
added IntegrationJira label
- Arturo Herrero added groupintegrations [DEPRECATED] label and removed groupecosystem [DEPRECATED] label
added groupintegrations [DEPRECATED] label and removed groupecosystem [DEPRECATED] label
- Libor Vanc made the issue confidential
made the issue confidential
- Arturo Herrero added atlassian label
added atlassian label
- 🤖 GitLab Bot 🤖 added 1 deleted label and removed devopscreate label
added 1 deleted label and removed devopscreate label
- Justin Mandell added 1 deleted label
added 1 deleted label
- Arturo Herrero marked this issue as related to #337107 (closed)
marked this issue as related to #337107 (closed)
- Maintainer
@lvanc Do we need to keep this issue confidential? I think #337107 (closed) could be related to this one. What do you think?
Collapse replies - Author Developer
@arturoherrero I don't think this issue needs to be confidential. I think is was initially setup this way because it was created off of https://gitlab.com/gitlab-org/competitor-evaluations/-/issues/13.
Also, yes, I think #337107 (closed) is related.
1
- Libor Vanc changed milestone to %Backlog
changed milestone to %Backlog
- Arturo Herrero made the issue visible to everyone
made the issue visible to everyone
- Grant Hickman changed epic to &1522
changed epic to &1522
- Libor Vanc unassigned @lvanc
unassigned @lvanc
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Arturo Herrero added maintenanceusability typemaintenance labels
added maintenanceusability typemaintenance labels
- 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label
added devopsmanage label and removed 1 deleted label
- Maintainer
Setting label(s) Category:Integrations based on ~"group::integrations".
- 🤖 GitLab Bot 🤖 added Category:Integrations label
added Category:Integrations label
- Author Developer
For awareness @g.hickman @Andysoiron
1 Collapse replies - Developer
- Developer
Noting that this issue appears to be a fix for Investigate GitLab for Jira Cloud app namespace... (#391242 - closed).
- Grant Hickman marked this issue as related to #391242 (closed)
marked this issue as related to #391242 (closed)
- 🤖 GitLab Bot 🤖 added groupimport and integrate label and removed groupintegrations [DEPRECATED] label
added groupimport and integrate label and removed groupintegrations [DEPRECATED] label
- Magdalena Frankiewicz added priority2 label and removed priority3 label
- Magdalena Frankiewicz changed epic to &10256
changed epic to &10256
- Magdalena Frankiewicz removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Magdalena Frankiewicz removed atlassian label
removed atlassian label
- Magdalena Frankiewicz added documentation label
added documentation label
- Magdalena Frankiewicz changed milestone to %16.1
changed milestone to %16.1
- Developer
This seems to contribute to many problems, so scheduling it for 16.1.
@lvanc could you help me understand, you wrote "When wanting to link a project", but then that namespace is actually a group. UI says "Link namespaces" - what so we want to link here then, group or project?
https://docs.gitlab.com/ee/integration/jira/connect-app.html#install-the-gitlab-for-jira-cloud-app says "namespace" and "You must have at least the Maintainer role for the GitLab namespace"
This part, https://docs.gitlab.com/ee/integration/jira/development_panel.html#connected-projects-in-gitlab, which I assume is valid for both GitLab for Jira Cloud app and Jira DVCS connector, talks about top-level groups and personal namespaces.
What can be linked to GitLab for Jira Cloud app? - any group, only top-level group, subgroup, project, personal namespace?
@Andysoiron I think I've asked you this already, apologies, could you state it here again?
@ashrafkhamis once this is clear, we need to document it, what can be linked, also what permissions are needed.
/cc @anton
2 Collapse replies - Maintainer
@m_frankiewicz this is indeed confusing. The GitLab for Jira Cloud app can only link groups. It works for top-level or subgroups. It does not work for projects or personal namespases.
- Developer
Oh, then we should adjust Improve Jira integrations docs (!118744 - merged).
I'll change 'namespaces' to 'groups' in that MR, for GitLab for Jira Cloud app, @ashrafkhamis
@Andysoiron how is it for DVCS connector? At the moment we see in docs, that with DVCS personal namespaces can be linked:
To connect additional GitLab projects from other GitLab top-level groups or personal namespaces, repeat the previous steps with additional Jira DVCS accounts.
Can Jira DVCS connector link subgroups?
Edited by Magdalena Frankiewicz 1 - Maintainer
@m_frankiewicz, I just checked the Atlassian documentation, and it looks like it can link subgroups. It says:
In the Team or User Account, enter the target group and optional subgroups.
1 - Maintainer
In that case should we update the description of this issue to also update all instances of "namespace" to "group"?
- Maintainer
@justin_ho Do we need additional input from UX or Technical Writing here or can we move this to workflowready for development?
- Maintainer
Just waiting on the question above to make sure we fix all the issues at once. I also realized I didn't tag @m_frankiewicz so she might have missed it.
Otherwise should be ready to be picked up next milestone.
- Developer
In that case should we update the description of this issue to also update all instances of "namespace" to "group"?
yes.
I updated description, please review. I wonder if it's possible (and useful) to link in the UI to the docs on the roles/permissions for the group.
@eread what do you think about the copy?
@justin_ho "search by name" means here "search by group name" right? Also, should this search field appear when user has no groups to link (because they're not the Maintainer or Owner of any group)?
@justin_ho @m_frankiewicz This would be my suggestion:
Link groups
Search...
No groups found
Only groups you have at least the Maintainer role for appear here.
WDYT?
CC @lvanc
- Developer
LGTM
1 - Author Developer
@m_frankiewicz Sorry for the delayed response. Just getting caught up here.
@eread your proposal looks good to me! I just update the link description with the latest.
- Developer
- Author Developer
@m_frankiewicz Good catch! We should show “Not seeing your groups?...” under group search field when user has permission to see some groups.
Has permission /cc @eread
2
- Magdalena Frankiewicz mentioned in issue gitlab-org/manage/general-discussion#17620
mentioned in issue gitlab-org/manage/general-discussion#17620
- Magdalena Frankiewicz mentioned in merge request !118744 (merged)
mentioned in merge request !118744 (merged)
- Martin Wortschack added ready for next refinement label
added ready for next refinement label
- Martin Wortschack mentioned in issue #409789 (closed)
mentioned in issue #409789 (closed)
- Justin Ho Tuan Duong set weight to 1
set weight to 1
- Martin Wortschack removed ready for next refinement label
removed ready for next refinement label
- Magdalena Frankiewicz changed the description
Compare with previous version changed the description
- Magdalena Frankiewicz added workflowrefinement label and removed workflowready for design label
added workflowrefinement label and removed workflowready for design label
- Magdalena Frankiewicz removed priority2 label
removed priority2 label
- Magdalena Frankiewicz removed severity4 label
removed severity4 label
- Magdalena Frankiewicz added frontend label
added frontend label
- Maintainer
All SUS-impacting issues need to have a proper severity label set. Please add a severity label, remove the automation:ux-missing-labels label, and then reply to this comment briefly explaining your reasoning for providing this severity.
If you are not the DRI for this area and would like help determining the best severity, please @ the appropriate person for assistance.
This message was generated automatically. You're welcome to improve it.
Collapse replies - Developer
@lvanc can you add a severity label? Thanks!
1 - Author Developer
Thanks @vkarnes!
- 🤖 GitLab Bot 🤖 added automation:ux-missing-labels label
added automation:ux-missing-labels label
- Martin Wortschack added Deliverable milestonep1 labels
added Deliverable milestonep1 labels
- Maintainer
Setting health status to
on track
as the milestone has just begun.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to on track
changed health status to on track
- Justin Ho Tuan Duong assigned to @justin_ho
assigned to @justin_ho
- Justin Ho Tuan Duong added workflowready for development label and removed workflowrefinement label
added workflowready for development label and removed workflowrefinement label
- Libor Vanc changed the description
Compare with previous version changed the description
- Maintainer
One more thing I noticed while working on this is that we seem to be inconsistent when using Link group and Add group interchangeably. For example:
- Sign in to GitLab to link groups. (button to sign in)
- Link groups (title of modal)
- Add group (button to open modal)
For the destructive action, we are using
Unlink
which only appears in a couple of places so it's consistent. Should we standardize to a single term (link
oradd
) to avoid confusion? @lvanc @eread Collapse replies - Developer
@justin_ho yes, we should use the same term, I think "link" or "unlink" everywhere.
1 1
- Magdalena Frankiewicz changed the description
Compare with previous version changed the description
- Libor Vanc added severity2 label
added severity2 label
- Valerie Karnes removed automation:ux-missing-labels label
removed automation:ux-missing-labels label
- Justin Ho Tuan Duong added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Justin Ho Tuan Duong mentioned in merge request !123000 (merged)
mentioned in merge request !123000 (merged)
- Justin Ho Tuan Duong added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Justin Ho Tuan Duong added workflowverification label and removed workflowin review label
added workflowverification label and removed workflowin review label
- Maintainer
Closing this as done and deployed to production.
- Justin Ho Tuan Duong closed
closed
- Justin Ho Tuan Duong added workflowcomplete label and removed workflowverification label
added workflowcomplete label and removed workflowverification label