Discussion: Move package file size limits to application settings
Background
The package max file size settings are currently set in plan_limits
, meaning a different size can be used for different plans.
There is no intent to have different limits for different plans, so having a different limit for each plan only creates problems when needing to add or update new limits.
We also have seen problems where self managed customers end up with multiple plans on their instance, and have a difficult time understanding how to properly update the package limits.
Another problem is that users expect these settings to be in the admin application settings menu and screen. Currently, they are there, however, they are the only non-application settings values to live in those forms, leading to some inconsistencies in the code.
Proposal
We should move the max file size settings to application_settings
so there is a single setting per instance. This will prevent further confusion about the feature.
Proposed backend implementations
-
Stick with current format, each package type has it's own setting column
-
Use a jsonb column to allow all package types to be stored in a single column:
{ conan_max_file_size: 300000000, maven_max_file_size: 500000000, ... }