[Feature flag] Enforce maximum attachment size in project API uploads (enforce_max_attachment_size_upload_api)
:enforce_max_attachment_size_upload_api feature flag ...
- Most appropriate slack channel to reach out to: #development
- Best individual to reach out to:
What are we expecting to happen?
Uploads made via the projects API that exceed 10 MB will be rejected: https://log.gprd.gitlab.net/goto/6d649736fc3dd7c9e62e59392bdd04e5
What might happen if this goes wrong?
Uploads made error out.
What can we monitor to detect problems with this?
- Rails upload log: https://log.gprd.gitlab.net/goto/6d649736fc3dd7c9e62e59392bdd04e5
- Workhorse status: https://log.gprd.gitlab.net/goto/515f62d1b55567b2c455245e2f886bc8
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
Roll Out Steps
Enable on staging (
/chatops run feature set enforce_max_attachment_size_upload_api true --staging)
Test on staging
Ensure that documentation has been updated: !59692 (merged)
Enable on GitLab.com for individual groups/projects listed above and verify behaviour (
/chatops run feature set --project=gitlab-org/gitlab feature_name true)
If it is possible to perform an incremental rollout, this should be preferred. Proposed increments are:
100%. Proposed minimum time between increments is 15 minutes.
Coordinate a time to enable the flag with the SRE oncall and release managers
@release-managers. Once an SRE on call and Release Manager on call confirm, you can proceed with the rollout
Announce on the issue an estimated time this will be enabled on GitLab.com. Note: Once a feature rollout has started, it is not necessary to inform
@release-managersat each stage of the gradual rollout.
Enable on GitLab.com by running chatops command in
/chatops run feature set enforce_max_attachment_size_upload_api true)
Cross post chatops Slack command to
#support_gitlab-com(more guidance when this is necessary in the dev docs) and in your team channel
Announce on the issue that the flag has been enabled
Remove feature flag and add changelog entry. Ensure that the feature flag definition YAML file has been removed in the same MR that is removing the feature flag from the code
After the flag removal is deployed, clean up the feature flag by running chatops command in
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab enforce_max_attachment_size_upload_api false