Move Gitlab::ErrorTracking classes to ErrorTracking namespace
After !55506 (merged), most of our our code relating to Category:Error Tracking is in the ErrorTracking
namespace. This is the desired state according to https://docs.gitlab.com/ee/development/directory_structure.html
However, we still have some classes in Gitlab::ErrorTracking
at lib/gitlab/error_tracking
:
- Most of these are models, so should be in
app/models
. - All of them should be under
ErrorTracking
rather thanGitlab::ErrorTracking
.
However, it's not trivial to change these, because they have global IDs exposed in our GraphQL API. An example of this can be found in our frontend specs: https://gitlab.com/gitlab-org/gitlab/-/blob/e5f50b707990e8c3cb6a529c3c5585daaf52955e/spec/frontend/error_tracking/components/error_details_spec.js#L178
gid://gitlab/Gitlab::ErrorTracking::DetailedError/129381
I don't think there's a good option here, other than maybe this:
- Allow these objects to be resolved as either
Gitlab::ErrorTracking::Foo
orErrorTracking::Foo
in global IDs. - Start emitting
ErrorTracking::Foo
. - Deprecate and eventually remove the
Gitlab::ErrorTracking
versions.
One more
!55506 (diffs, comment 520339361)
This seems like it should be describing
ErrorTracking::SentryClient::Event
, but I was trying to avoid functional changes.