Update references to "issuable_vue_app:change" to use constant
Context
In !52135 (comment 493847316) we encapsulated the event string "issuable_vue_app:change"
in a constant, but the constant is only referenced in a single module.
Instructions
- Let's move this constant to
app/assets/javascripts/issuable/constants.js
(to avoid cyclical dependencies) - Let's update all references to
"issuable_vue_app:change"
to use this constant.
$ git grep -e issuable_vue_app:change
app/assets/javascripts/issue.js:export const EVENT_ISSUABLE_VUE_APP_CHANGE = 'issuable_vue_app:change';
app/assets/javascripts/issue_show/components/header_actions.vue: document.dispatchEvent(new CustomEvent('issuable_vue_app:change', payload));
app/assets/javascripts/notes/stores/actions.js: const event = new CustomEvent('issuable_vue_app:change', {
ee/app/assets/javascripts/epic/components/epic_header.vue: epicUtils.bindDocumentEvent('issuable_vue_app:change', (e, isClosed) => {
ee/app/assets/javascripts/epic/store/actions.js: epicUtils.triggerDocumentEvent('issuable_vue_app:change', isEpicOpen);
ee/spec/frontend/epic/store/actions_spec.js: it('Calls `triggerDocumentEvent` with events `issuable_vue_app:change`, `issuable:change` and passes `isEpicOpen` as param', () => {
ee/spec/frontend/epic/store/actions_spec.js: 'issuable_vue_app:change',
spec/frontend/notes/stores/actions_spec.js: document.addEventListener('issuable_vue_app:change', (event) => {
/cc @codeEmitter
Edited by Paul Slaughter