Update redis_hll_counters.search.search_total_unique_counts_monthly as deprecated
The following discussion from !54539 (merged) should be addressed:
-
@DylanGriffith started a discussion: These keys confused me at first because I couldn't grep them but eventually digging through the code I see this is generated at https://gitlab.com/gitlab-org/gitlab/blob/master/lib/gitlab/usage_data_counters/hll_redis_counter.rb#L89 .
I'm actually not sure what is the correct description for this one, however, because we already have
i_search_total
and that makes me think that this value will be a sum oftotal + advanced + paid
which will all be quite redundant because paid will be a subset of advanced and advanced will be a subset of total. Is there a way we can disable this metric if it's just summing a bunch of overlapping numbers or am I reading it wrong?
Proposal
Update the metric as deprecated after checking it is now used in any dashboard.